viirya commented on code in PR #111:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/111#discussion_r1502107272
##########
core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -1098,47 +1113,47 @@ fn make_dict_builder(datatype: &DataType, capacity:
usize) -> Box<dyn ArrayBuild
if matches!(value_type.as_ref(), DataType::LargeUtf8) =>
{
match key_type.as_ref() {
- DataType::Int8 => string_dict_builder_inner_helper!(
- Int16Type,
+ DataType::Int8 => byte_dict_builder_inner_helper!(
+ Int8Type,
Review Comment:
Yea, it is a typo. More test coverage is good. As there are too many
combinations, we probably miss some in current test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
