crepererum commented on code in PR #9307:
URL: https://github.com/apache/arrow-datafusion/pull/9307#discussion_r1502369803
##########
datafusion-cli/src/catalog.rs:
##########
@@ -145,16 +146,24 @@ impl SchemaProvider for DynamicFileSchemaProvider {
self.inner.register_table(name, table)
}
- async fn table(&self, name: &str) -> Option<Arc<dyn TableProvider>> {
- let inner_table = self.inner.table(name).await;
+ async fn table(
+ &self,
+ name: &str,
+ ) -> Result<Option<Arc<dyn TableProvider>>, DataFusionError> {
+ let inner_table = self.inner.table(name).await?;
if inner_table.is_some() {
- return inner_table;
+ return Ok(inner_table);
}
// if the inner schema provider didn't have a table by
// that name, try to treat it as a listing table
- let state = self.state.upgrade()?.read().clone();
- let table_url = ListingTableUrl::parse(name).ok()?;
+ let state = self
+ .state
+ .upgrade()
+ .ok_or_else(|| DataFusionError::Plan("locking error".to_owned()))?
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
