alamb commented on code in PR #9307:
URL: https://github.com/apache/arrow-datafusion/pull/9307#discussion_r1503071829
##########
datafusion-cli/src/catalog.rs:
##########
@@ -145,16 +146,24 @@ impl SchemaProvider for DynamicFileSchemaProvider {
self.inner.register_table(name, table)
}
- async fn table(&self, name: &str) -> Option<Arc<dyn TableProvider>> {
- let inner_table = self.inner.table(name).await;
+ async fn table(
+ &self,
+ name: &str,
+ ) -> Result<Option<Arc<dyn TableProvider>>, DataFusionError> {
Review Comment:
The rest of the file uses this style, so I think the `DataFusionError` is
unecessary
```suggestion
) -> Result<Option<Arc<dyn TableProvider>>> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
