pitrou commented on code in PR #40206:
URL: https://github.com/apache/arrow/pull/40206#discussion_r1504239196
##########
cpp/src/arrow/compute/kernels/vector_selection_benchmark.cc:
##########
@@ -322,6 +367,36 @@ static void
TakeFixedSizeBinaryMonotonicIndices(benchmark::State& state) {
.FixedSizeBinary();
}
+static void TakeChunkedChunkedInt64RandomIndicesNoNulls(benchmark::State&
state) {
+ TakeBenchmark(state, false)
+ .ChunkedInt64(/*num_chunks=*/100, /*chunk_indices_too=*/true);
+}
+
+static void TakeChunkedChunkedInt64RandomIndicesWithNulls(benchmark::State&
state) {
+ TakeBenchmark(state, true).ChunkedInt64(/*num_chunks=*/100,
/*chunk_indices_too=*/true);
+}
+
+static void TakeChunkedChunkedInt64MonotonicIndices(benchmark::State& state) {
+ TakeBenchmark(state, /*indices_with_nulls=*/false, /*monotonic=*/true)
+ .ChunkedInt64(
+ /*num_chunks=*/100, /*chunk_indices_too=*/true);
+}
+
+static void TakeChunkedFlatInt64RandomIndicesNoNulls(benchmark::State& state) {
+ TakeBenchmark(state, false)
+ .ChunkedInt64(/*num_chunks=*/100, /*chunk_indices_too=*/true);
Review Comment:
If this is meant to be "flat", do you mean `/*chunk_indices_too=*/false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
