pitrou commented on PR #40206:
URL: https://github.com/apache/arrow/pull/40206#issuecomment-1966570687
The added benchmarks are improved a lot by the algorithmic changes. Neat!
```
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Non-regressions: (30)
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark baseline
contender change %
counters
TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/1 42.356M items/sec
990.369M items/sec 2238.183 {'family_index': 1, 'per_family_instance_index':
3, 'run_name': 'TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/1',
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 57,
'null_percent': 100.0}
TakeChunkedFlatInt64RandomIndicesWithNulls/524288/1 44.822M items/sec
968.170M items/sec 2060.035 {'family_index': 4,
'per_family_instance_index': 3, 'run_name':
'TakeChunkedFlatInt64RandomIndicesWithNulls/524288/1', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 59, 'null_percent': 100.0}
TakeChunkedChunkedInt64MonotonicIndices/524288/1 41.670M items/sec
427.030M items/sec 924.791 {'family_index': 2,
'per_family_instance_index': 3, 'run_name':
'TakeChunkedChunkedInt64MonotonicIndices/524288/1', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 56, 'null_percent': 100.0}
TakeChunkedFlatInt64MonotonicIndices/524288/1 43.028M items/sec
434.987M items/sec 910.949 {'family_index': 5,
'per_family_instance_index': 3, 'run_name':
'TakeChunkedFlatInt64MonotonicIndices/524288/1', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 57, 'null_percent': 100.0}
TakeChunkedFlatInt64RandomIndicesNoNulls/524288/1 41.435M items/sec
416.685M items/sec 905.646 {'family_index': 3,
'per_family_instance_index': 3, 'run_name':
'TakeChunkedFlatInt64RandomIndicesNoNulls/524288/1', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 55, 'null_percent': 100.0}
TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/1 41.287M items/sec
413.244M items/sec 900.913 {'family_index': 0,
'per_family_instance_index': 3, 'run_name':
'TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/1', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 55, 'null_percent': 100.0}
TakeChunkedChunkedInt64MonotonicIndices/524288/0 47.665M items/sec
470.231M items/sec 886.531 {'family_index': 2,
'per_family_instance_index': 4, 'run_name':
'TakeChunkedChunkedInt64MonotonicIndices/524288/0', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 64, 'null_percent': 0.0}
TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/0 44.595M items/sec
424.955M items/sec 852.910 {'family_index': 1,
'per_family_instance_index': 4, 'run_name':
'TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/0', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 61, 'null_percent': 0.0}
TakeChunkedFlatInt64MonotonicIndices/524288/0 48.917M items/sec
465.193M items/sec 850.976 {'family_index': 5,
'per_family_instance_index': 4, 'run_name':
'TakeChunkedFlatInt64MonotonicIndices/524288/0', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 65, 'null_percent': 0.0}
TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/0 47.166M items/sec
414.813M items/sec 779.479 {'family_index': 0,
'per_family_instance_index': 4, 'run_name':
'TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/0', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 63, 'null_percent': 0.0}
TakeChunkedFlatInt64RandomIndicesNoNulls/524288/0 48.511M items/sec
422.180M items/sec 770.278 {'family_index': 3,
'per_family_instance_index': 4, 'run_name':
'TakeChunkedFlatInt64RandomIndicesNoNulls/524288/0', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 63, 'null_percent': 0.0}
TakeChunkedFlatInt64RandomIndicesWithNulls/524288/0 48.690M items/sec
416.701M items/sec 755.819 {'family_index': 4,
'per_family_instance_index': 4, 'run_name':
'TakeChunkedFlatInt64RandomIndicesWithNulls/524288/0', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 64, 'null_percent': 0.0}
TakeChunkedChunkedInt64MonotonicIndices/524288/1000 40.203M items/sec
306.199M items/sec 661.631 {'family_index': 2,
'per_family_instance_index': 0, 'run_name':
'TakeChunkedChunkedInt64MonotonicIndices/524288/1000', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 53, 'null_percent': 0.1}
TakeChunkedFlatInt64MonotonicIndices/524288/1000 41.141M items/sec
303.560M items/sec 637.846 {'family_index': 5,
'per_family_instance_index': 0, 'run_name':
'TakeChunkedFlatInt64MonotonicIndices/524288/1000', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 55, 'null_percent': 0.1}
TakeChunkedChunkedInt64MonotonicIndices/524288/10 38.784M items/sec
254.283M items/sec 555.638 {'family_index': 2,
'per_family_instance_index': 1, 'run_name':
'TakeChunkedChunkedInt64MonotonicIndices/524288/10', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 52, 'null_percent': 10.0}
TakeChunkedFlatInt64MonotonicIndices/524288/10 40.112M items/sec
254.035M items/sec 533.320 {'family_index': 5,
'per_family_instance_index': 1, 'run_name':
'TakeChunkedFlatInt64MonotonicIndices/524288/10', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 53, 'null_percent': 10.0}
TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/1000 37.405M items/sec
228.050M items/sec 509.682 {'family_index': 0, 'per_family_instance_index':
0, 'run_name': 'TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/1000',
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 46,
'null_percent': 0.1}
TakeChunkedFlatInt64RandomIndicesNoNulls/524288/1000 37.929M items/sec
230.621M items/sec 508.029 {'family_index': 3,
'per_family_instance_index': 0, 'run_name':
'TakeChunkedFlatInt64RandomIndicesNoNulls/524288/1000', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 51, 'null_percent': 0.1}
TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/1000 37.423M items/sec
217.546M items/sec 481.314 {'family_index': 1, 'per_family_instance_index':
0, 'run_name': 'TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/1000',
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 50,
'null_percent': 0.1}
TakeChunkedFlatInt64RandomIndicesWithNulls/524288/1000 37.925M items/sec
218.967M items/sec 477.367 {'family_index': 4,
'per_family_instance_index': 0, 'run_name':
'TakeChunkedFlatInt64RandomIndicesWithNulls/524288/1000', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 51, 'null_percent': 0.1}
TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/10 37.092M items/sec
209.418M items/sec 464.590 {'family_index': 0,
'per_family_instance_index': 1, 'run_name':
'TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/10', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 49, 'null_percent': 10.0}
TakeChunkedFlatInt64RandomIndicesNoNulls/524288/10 38.211M items/sec
210.413M items/sec 450.660 {'family_index': 3,
'per_family_instance_index': 1, 'run_name':
'TakeChunkedFlatInt64RandomIndicesNoNulls/524288/10', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 51, 'null_percent': 10.0}
TakeChunkedChunkedInt64MonotonicIndices/524288/2 36.703M items/sec
189.921M items/sec 417.456 {'family_index': 2,
'per_family_instance_index': 2, 'run_name':
'TakeChunkedChunkedInt64MonotonicIndices/524288/2', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 50, 'null_percent': 50.0}
TakeChunkedFlatInt64MonotonicIndices/524288/2 38.049M items/sec
188.632M items/sec 395.761 {'family_index': 5,
'per_family_instance_index': 2, 'run_name':
'TakeChunkedFlatInt64MonotonicIndices/524288/2', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 51, 'null_percent': 50.0}
TakeChunkedFlatInt64RandomIndicesNoNulls/524288/2 35.089M items/sec
152.790M items/sec 335.432 {'family_index': 3,
'per_family_instance_index': 2, 'run_name':
'TakeChunkedFlatInt64RandomIndicesNoNulls/524288/2', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 46, 'null_percent': 50.0}
TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/2 34.968M items/sec
152.119M items/sec 335.027 {'family_index': 0,
'per_family_instance_index': 2, 'run_name':
'TakeChunkedChunkedInt64RandomIndicesNoNulls/524288/2', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 47, 'null_percent': 50.0}
TakeChunkedFlatInt64RandomIndicesWithNulls/524288/10 35.519M items/sec
152.181M items/sec 328.450 {'family_index': 4,
'per_family_instance_index': 1, 'run_name':
'TakeChunkedFlatInt64RandomIndicesWithNulls/524288/10', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 47, 'null_percent': 10.0}
TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/10 34.179M items/sec
134.705M items/sec 294.115 {'family_index': 1, 'per_family_instance_index':
1, 'run_name': 'TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/10',
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 46,
'null_percent': 10.0}
TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/2 30.641M items/sec
100.546M items/sec 228.138 {'family_index': 1, 'per_family_instance_index':
2, 'run_name': 'TakeChunkedChunkedInt64RandomIndicesWithNulls/524288/2',
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 41,
'null_percent': 50.0}
TakeChunkedFlatInt64RandomIndicesWithNulls/524288/2 31.772M items/sec
100.508M items/sec 216.344 {'family_index': 4,
'per_family_instance_index': 2, 'run_name':
'TakeChunkedFlatInt64RandomIndicesWithNulls/524288/2', 'repetitions': 1,
'repetition_index': 0, 'threads': 1, 'iterations': 42, 'null_percent': 50.0}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]