DDtKey commented on code in PR #9189: URL: https://github.com/apache/arrow-datafusion/pull/9189#discussion_r1504553431
########## datafusion/common/src/wasm.rs: ########## Review Comment: Just one question: it's wrapper for `Instant`, but module name is `wasm` while "wasm" it or not depends on target family A bit confusing to use `wasm::Instant` in code, like it's something specific, e.g https://github.com/apache/arrow-datafusion/blob/857a2e34299b7ec5be97b40a5019b15d0fc23bd0/datafusion/core/benches/parquet_query_sql.rs#L28 Shouldn't it be `common::instant::Instant` instead? This way we fully encapsulate wrapper and can easily extend in the future if we wish -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
