waynexia commented on PR #9189: URL: https://github.com/apache/arrow-datafusion/pull/9189#issuecomment-1968167780
> > I wonder if you want to put an "exclude" type lint in to prevent people from accidentally using std::time::Instant > > Unfortunately, I think it's not possible "as is" for this case, because it's actually just a type alias. However new-type pattern would work (wrap `Instant` into new type instead of type-alias) > > Somebody already tried, btw: [rust-lang/rust-clippy#10406](https://github.com/rust-lang/rust-clippy/issues/10406) TIL, thanks for your information. I find `disallowed_type` works for our case: https://github.com/apache/arrow-datafusion/pull/9189/commits/edb67fae06bbddb080fae7e6b57b97d5236f8c56, it seems work by matching the import types and won't follow type alias 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
