viirya commented on code in PR #100:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/100#discussion_r1505532251
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -173,6 +181,17 @@ abstract class CometTestBase
}
}
+ protected def checkPlanContains(plan: SparkPlan, includePlans: Class[_]*):
Unit = {
+ includePlans.foreach { case planClass =>
+ if (!plan.exists(op => planClass.isAssignableFrom(op.getClass))) {
+ assert(
+ false,
+ s"Expected plan to contain ${planClass.getSimpleName}.\n" +
Review Comment:
```suggestion
s"Expected plan to contain ${planClass.getSimpleName} but not.\n" +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
