viirya commented on code in PR #100:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/100#discussion_r1505533040
##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -1073,6 +1073,34 @@ class CometExecSuite extends CometTestBase {
}
})
}
+
+ test("collect limit") {
+ Seq("true", "false").foreach(aqe => {
+ withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> aqe) {
+ withParquetTable((0 until 5).map(i => (i, i + 1)), "tbl") {
+ val df = sql("SELECT _1 as id, _2 as value FROM tbl limit 2")
+ assert(df.queryExecution.executedPlan.execute().getNumPartitions ===
1)
+ checkSparkAnswerAndOperator(df, Seq(classOf[CometCollectLimitExec]))
+ assert(df.collect().length === 2)
+
+ // checks CometCollectExec.doExecuteColumnar is indirectly called
Review Comment:
This comment looks weird. Do you mean "Executes CometCollectExec directly"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
