Omega359 commented on code in PR #9388:
URL: https://github.com/apache/arrow-datafusion/pull/9388#discussion_r1506368830


##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1530,14 +1531,26 @@ mod tests {
 
         // Check non string arguments
         // to_timestamp("2020-09-08T12:00:00+00:00") --> 
timestamp(1599566400i64)
-        let expr =
-            call_fn("to_timestamp", 
vec![lit("2020-09-08T12:00:00+00:00")]).unwrap();
-        test_evaluate(expr, lit_timestamp_nano(1599566400000000000i64));
+        //
+        // todo - determine how to migrate this

Review Comment:
   I currently don't know how this could be enabled again because of the issues 
with the fact that this calls into private code in this module. Any ideas would 
be appreciated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to