Omega359 commented on code in PR #9388:
URL: https://github.com/apache/arrow-datafusion/pull/9388#discussion_r1506684514
##########
datafusion/optimizer/src/simplify_expressions/simplify_exprs.rs:
##########
@@ -505,59 +488,6 @@ mod tests {
Ok(())
}
- #[test]
- fn now_less_than_timestamp() -> Result<()> {
Review Comment:
There are in fact two problems with the commented out code.
1. call_fn only works for BuiltinScalarFunction. Easy to work around by
using a direct function call (once the test is moved)
2. test_evaluate calls test_evaluate_with_start_time which builds a
ConstEvaluator directly. Calling the entire simplifier on them should fix this
issue - the fix is really in test_evaluate_with_start_time function (when
moved). Moving that will basically mean all the test_evaluate functions would
be moved over as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
