alamb commented on code in PR #9389:
URL: https://github.com/apache/arrow-datafusion/pull/9389#discussion_r1506446574
##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -455,6 +443,22 @@ impl ExecutionPlanProperties for Arc<dyn ExecutionPlan> {
///
/// See also [`ExecutionPlan::maintains_input_order`] and
[`Self::output_ordering`]
/// for related concepts.
+ fn equivalence_properties(&self) -> &EquivalenceProperties;
Review Comment:
github rendered the diff strangely -- what I did was move the comments into
the trait
##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -519,20 +523,21 @@ fn execution_mode_from_children<'a>(
result
}
-/// Stores the plan properties used in query optimization.
+/// Stores certain, often expensive to compute, plan properties used in query
+/// optimization.
///
-/// These properties are in a single structure to permit this information to
be computed
-/// once and then those cached results used multiple times without
recomputation (aka a cache)
+/// These properties are stored a single structure to permit this information
to
+/// be computed once and then those cached results used multiple times without
+/// recomputation (aka a cache)
#[derive(Debug, Clone)]
pub struct PlanProperties {
- /// Stores the [`EquivalenceProperties`] of the [`ExecutionPlan`].
+ /// See [ExecutionPlanProperties::equivalence_properties]
pub eq_properties: EquivalenceProperties,
- /// Stores the output [`Partitioning`] of the [`ExecutionPlan`].
+ /// See [ExecutionPlanProperties::output_partitioning]
pub partitioning: Partitioning,
- /// Stores the [`ExecutionMode`] of the [`ExecutionPlan`].
- pub exec_mode: ExecutionMode,
- /// Stores output ordering of the [`ExecutionPlan`]. A `None` value
represents
- /// no ordering.
+ /// See [ExecutionPlanProperties::execution_mode]
+ pub execution_mode: ExecutionMode,
Review Comment:
A drive by change was to rename this field to match the trait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
