ozankabak commented on code in PR #9389:
URL: https://github.com/apache/arrow-datafusion/pull/9389#discussion_r1506718374


##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -455,6 +443,22 @@ impl ExecutionPlanProperties for Arc<dyn ExecutionPlan> {
     ///
     /// See also [`ExecutionPlan::maintains_input_order`] and 
[`Self::output_ordering`]
     /// for related concepts.
+    fn equivalence_properties(&self) -> &EquivalenceProperties;
+}
+
+impl ExecutionPlanProperties for Arc<dyn ExecutionPlan> {

Review Comment:
   ```suggestion
   impl ExecutionPlanProperties for dyn ExecutionPlan {
   ```
   Maybe doing this will make the extension trait a bit more generally 
applicable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to