advancedxy commented on code in PR #83:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/83#discussion_r1507055191
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -65,28 +64,18 @@ abstract class CometTestBase
val conf = new SparkConf()
conf.set("spark.hadoop.fs.file.impl", classOf[DebugFilesystem].getName)
conf.set(SQLConf.SHUFFLE_PARTITIONS, 10) // reduce parallelism in tests
- conf.set("spark.shuffle.manager", shuffleManager)
+ conf.set(SQLConf.ANSI_ENABLED.key, "false")
+ conf.set(SHUFFLE_MANAGER, shuffleManager)
+ conf.set(MEMORY_OFFHEAP_ENABLED.key, "true")
Review Comment:
> I already made one change in Spark:
https://github.com/apache/spark/pull/45052 for this. We'll need a few more
changes so we can completely overwrite executor memory setting through
DriverPlugin.
Great work. Looking forward that we can completely overwrite memory settings
through DriverPlugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
