viirya commented on code in PR #83:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/83#discussion_r1510667483
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -65,28 +64,18 @@ abstract class CometTestBase
val conf = new SparkConf()
conf.set("spark.hadoop.fs.file.impl", classOf[DebugFilesystem].getName)
conf.set(SQLConf.SHUFFLE_PARTITIONS, 10) // reduce parallelism in tests
- conf.set("spark.shuffle.manager", shuffleManager)
+ conf.set(SQLConf.ANSI_ENABLED.key, "false")
+ conf.set(SHUFFLE_MANAGER, shuffleManager)
+ conf.set(MEMORY_OFFHEAP_ENABLED.key, "true")
+ conf.set(MEMORY_OFFHEAP_SIZE.key, "2g")
+ conf.set(CometConf.COMET_ENABLED.key, "true")
+ conf.set(CometConf.COMET_EXEC_ENABLED.key, "true")
+ conf.set(CometConf.COMET_EXEC_ALL_OPERATOR_ENABLED.key, "true")
+ conf.set(CometConf.COMET_EXEC_ALL_EXPR_ENABLED.key, "true")
conf.set(CometConf.COMET_MEMORY_OVERHEAD.key, "2g")
conf
}
- override protected def test(testName: String, testTags: Tag*)(testFun: =>
Any)(implicit
- pos: Position): Unit = {
- super.test(testName, testTags: _*) {
- withSQLConf(
- CometConf.COMET_ENABLED.key -> "true",
- CometConf.COMET_EXEC_ENABLED.key -> "true",
- CometConf.COMET_EXEC_ALL_OPERATOR_ENABLED.key -> "true",
- CometConf.COMET_EXEC_ALL_EXPR_ENABLED.key -> "true",
- CometConf.COMET_COLUMNAR_SHUFFLE_MEMORY_SIZE.key -> "2g",
- SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "1g",
- SQLConf.ADAPTIVE_AUTO_BROADCASTJOIN_THRESHOLD.key -> "1g",
Review Comment:
For broadcast join threshold configs, should we keep them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
