joellubi commented on code in PR #40284:
URL: https://github.com/apache/arrow/pull/40284#discussion_r1508266351
##########
cpp/src/arrow/flight/sql/server_session_middleware.cc:
##########
@@ -80,7 +80,7 @@ class ServerSessionMiddlewareImpl : public
ServerSessionMiddleware {
Status CloseSession() override {
const std::lock_guard<std::shared_mutex> l(mutex_);
- if (static_cast<bool>(session_)) {
+ if (!static_cast<bool>(session_)) {
Review Comment:
Yes the C++ server scenario was failing when I added a test to the Go client
scenario that attempts to close the currently open session. I'm not especially
familiar with C++, but my understanding is that this was previously saying that
"if the session DOES exist, then it is an error to close it" which seems
backwards. Is my understanding accurate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
