indigophox commented on code in PR #40284:
URL: https://github.com/apache/arrow/pull/40284#discussion_r1508318481
##########
cpp/src/arrow/flight/sql/server_session_middleware.cc:
##########
@@ -80,7 +80,7 @@ class ServerSessionMiddlewareImpl : public
ServerSessionMiddleware {
Status CloseSession() override {
const std::lock_guard<std::shared_mutex> l(mutex_);
- if (static_cast<bool>(session_)) {
+ if (!static_cast<bool>(session_)) {
Review Comment:
Notably if you continue on with the same client cookie middleware in any
integration test after closing the session from the client, calls are going to
get failed out by the C++ server session middleware because the client cookie
middleware will submit a now-invalid session token (that the server was unable
to invalidate) with the request headers. This is fixable pending #40071.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
