advancedxy commented on code in PR #136:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/136#discussion_r1508368417
##########
Makefile:
##########
@@ -21,25 +21,22 @@ all: core jvm
core:
cd core && cargo build
-jvm:
- ./mvnw clean package -DskipTests $(PROFILES)
-test:
- ./mvnw clean
+test-rust:
# We need to compile CometException so that the cargo test can pass
./mvnw compile -pl common -DskipTests $(PROFILES)
cd core && cargo build && \
-
LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+${LD_LIBRARY_PATH}:}${JAVA_HOME}/lib:${JAVA_HOME}/lib/server:${JAVA_HOME}/lib/jli
&& \
-
DYLD_LIBRARY_PATH=${DYLD_LIBRARY_PATH:+${DYLD_LIBRARY_PATH}:}${JAVA_HOME}/lib:${JAVA_HOME}/lib/server:${JAVA_HOME}/lib/jli
\
RUST_BACKTRACE=1 cargo test
+jvm:
+ ./mvnw clean package -DskipTests $(PROFILES)
+test-jvm: core
SPARK_HOME=`pwd` COMET_CONF_DIR=$(shell pwd)/conf RUST_BACKTRACE=1
./mvnw verify $(PROFILES)
+test: test-rust test-jvm
Review Comment:
After this change, the `test` target is different with the previous one as
it doesn't execute `./mvn clean` first.
I think it would be surprise to find out that the JVM side's compiled
classes are all pruned due to execution of `make test-rust`.
If it's necessary to keep the exact behavior, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
