snmvaughan commented on code in PR #136:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/136#discussion_r1509233795
##########
.github/actions/rust-test/action.yaml:
##########
@@ -51,24 +51,10 @@ runs:
shell: bash
run: |
cd common
- if [ $JAVA_VERSION == "1.8" ]; then
- ../mvnw -B clean compile -DskipTests -Djava.version=${JAVA_VERSION}
-Dspotless.version=2.29.0
- else
- ../mvnw -B clean compile -DskipTests -Djava.version=${JAVA_VERSION}
- fi
+ ../mvnw -B clean compile -DskipTests
- name: Run Cargo test
shell: bash
run: |
cd core
- # This is required to run some JNI related tests on the Rust side
-
JAVA_LD_LIBRARY_PATH=$JAVA_HOME/lib/server:$JAVA_HOME/lib:$JAVA_HOME/lib/jli
Review Comment:
The rationale mentions 1.8, but it only works for 11 and 17
> make and mvn commands should just work out of box for JDK 1.8, 11 and 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
