thinkharderdev commented on code in PR #9395:
URL: https://github.com/apache/arrow-datafusion/pull/9395#discussion_r1509507556
##########
datafusion/proto/Cargo.toml:
##########
@@ -55,5 +55,6 @@ serde_json = { workspace = true, optional = true }
[dev-dependencies]
doc-comment = { workspace = true }
+regex = "1.10.3"
Review Comment:
I think the test works just fine without actually having `regex`. We can
just make the example like
```
struct MyRegexUdf {
pattern: String
}
```
so we don't need to add an extra dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
