thinkharderdev commented on PR #9395: URL: https://github.com/apache/arrow-datafusion/pull/9395#issuecomment-1974834031
> > @yyy1000 We do still need to handle serde for physical expressions as well. This would follow the same pattern as for logical expressions. > > > > > > We can either do that here or in a follow up PR. If you'd rather do it in follow-up PR then I wouldn't object to merging this one as is as I think being able to serialize the logical plan is a useful feature on it's own > > > > Hi, @thinkharderdev > > I'd like to work on a follow-up PR for physical-expr and merge this first, for two reasons. > > 1. This PR will lead conflict for the moving of functions. So merging this first will not need resolving conflicts regularly. :) > > 2. The change lines would be too large if this PR also includes for physical-expr, which may not be good for future review. > > > > Thank you again for your guidance and review, it's so helpful! Yep makes sense. No worries! Thanks for your work on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
