alamb commented on code in PR #9396:
URL: https://github.com/apache/arrow-datafusion/pull/9396#discussion_r1510010540
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -2628,6 +2530,87 @@ mod tests {
Int32Array
);
#[cfg(feature = "unicode_expressions")]
+ test_function!(
Review Comment:
Thank you @SteveLauC
Any chance you would be willing to port these tests to sqllogictests (as a
follow on PR)? They can probably be implemented easily in
https://github.com/apache/arrow-datafusion/blob/83d15e8b223e1af2c553ec54afa5c1ffac7c340e/datafusion/sqllogictest/test_files/scalar.slt#L4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
