SteveLauC commented on code in PR #9396:
URL: https://github.com/apache/arrow-datafusion/pull/9396#discussion_r1510107111
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -2628,6 +2530,87 @@ mod tests {
Int32Array
);
#[cfg(feature = "unicode_expressions")]
+ test_function!(
Review Comment:
Thanks for your review!
> Any chance you would be willing to port these tests to sqllogictests (as a
follow on PR)?
Sure, I wil do it in another PR:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
