comphead commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1510016448
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -794,6 +797,55 @@ impl SessionContext {
Ok(false)
}
+ async fn create_function(&self, stmt: CreateFunction) -> Result<DataFrame>
{
+ let function = {
+ let state = self.state.read().clone();
+ let function_factory = &state.function_factory;
+
+ match function_factory {
+ Some(f) => f.create(state.config(), stmt).await?,
+ _ => Err(DataFusionError::Configuration(
+ "Function factory has not been configured".into(),
+ ))?,
+ }
+ };
+
+ match function {
+ RegisterFunction::Scalar(f) => {
+ self.state.write().register_udf(f)?;
+ }
+ RegisterFunction::Aggregate(f) => {
+ self.state.write().register_udaf(f)?;
+ }
+ RegisterFunction::Window(f) => {
+ self.state.write().register_udwf(f)?;
+ }
+ RegisterFunction::Table(name, f) => self.register_udtf(&name, f),
+ };
+
+ self.return_empty_dataframe()
+ }
+
+ async fn drop_function(&self, stmt: DropFunction) -> Result<DataFrame> {
+ // we don't know function type at this point
+ // decision has been made to drop all functions
+ let mut dropped = false;
+ dropped |= self.state.write().deregister_udf(&stmt.name)?.is_some();
+ dropped |= self.state.write().deregister_udaf(&stmt.name)?.is_some();
+ dropped |= self.state.write().deregister_udwf(&stmt.name)?.is_some();
+
+ // DROP FUNCTION IF EXISTS drops the specified function only if that
+ // function exists and in this way, it avoids error. While the DROP
FUNCTION
+ // statement also performs the same function, it throws an
+ // error if the function does not exist.
+
+ if !stmt.if_exists && !dropped {
+ Err(DataFusionError::Execution("Function does not exist".into()))
Review Comment:
please use `exec_err!` macros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
