milenkovicm commented on PR #9333:
URL: 
https://github.com/apache/arrow-datafusion/pull/9333#issuecomment-1974878093

   > > > Thanks @milenkovicm I would say it is nice to get also tests what will 
happen if the function is invalid/not compilable or something
   > > > another question if function can call another function?
   > > 
   > > 
   > > Thanks for your comments @comphead , can you please elaborate your 
comment, thanks
   > 
   > Its great to have a test with invalid function, the function which is not 
parseable or compilable.
   
   could be added, no problem
   
   > And the next question if the user created functions `f1` and `f2`, can 
`f1` be called inside `f2`?
   
   I see two cases here:
   1. if we have functions defined in rust, there is no change to current 
behaviour I believe
   2. if we have `SQL UDF` then analyser should replace f1 first, then f2, so 
it should run as well
   
   do i miss something here?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to