alamb commented on code in PR #40243:
URL: https://github.com/apache/arrow/pull/40243#discussion_r1510208251
##########
docs/source/format/FlightSql.rst:
##########
@@ -141,6 +141,9 @@ the ``type`` should be ``ClosePreparedStatement``).
Execute a previously created prepared statement and get the results.
When used with DoPut: binds parameter values to the prepared statement.
+ The server may optionally respond with an updated handle. The client
+ should use this updated handle for all subsequent requests for this
+ prepared statement.
Review Comment:
```suggestion
should use this updated handle for all subsequent requests for this
prepared statement. The updated handle allows implementing query
parameters with stateless services. Note that the server is responsible
for detecting the case where the client does not use the updated handle
on
subsequent requests (older clients may ignore this field) and responding
appropriately.
```
##########
format/FlightSql.proto:
##########
@@ -1797,6 +1797,15 @@ message DoPutUpdateResult {
int64 record_count = 1;
}
+// An optional response returned when `DoPut` is called with
`CommandPreparedStatementQuery`
+message DoPutPreparedStatementResult {
+ option (experimental) = true;
+
+ // (potentially updated) opaque handle for the prepared statement on the
server.
+ // All subsequent requests for this prepared statement must use this new
handle, if specified
Review Comment:
I think it might help to give a hint here about what this field is used for
```suggestion
// All subsequent requests for this prepared statement must use this new
handle, if specified.
// The updated handle allows implementing query parameters with stateless
services
// as described in https://github.com/apache/arrow/issues/37720
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
