thinkharderdev commented on code in PR #9436:
URL: https://github.com/apache/arrow-datafusion/pull/9436#discussion_r1510244774
##########
datafusion/physical-expr/src/scalar_function.rs:
##########
@@ -44,12 +44,12 @@ use arrow::record_batch::RecordBatch;
use datafusion_common::Result;
use datafusion_expr::{
expr_vec_fmt, BuiltinScalarFunction, ColumnarValue, FuncMonotonicity,
- ScalarFunctionImplementation,
+ ScalarFunctionDefinition, ScalarFunctionImplementation,
};
/// Physical expression of a scalar function
pub struct ScalarFunctionExpr {
- fun: ScalarFunctionImplementation,
+ fun: ScalarFunctionDefinition,
Review Comment:
yeah, this should be `ScalarFunctionDefinition` here. I don't think
`create_udf` will be deprecated but we have `ScalarUdfLegacyWrapper` to wrap
`ScalarFunctionImplementation` and create a `ScalarUDFImpl` out of it. So the
new `ScalarFunctionDefinition` would include anything that is represented as a
`ScalarFunctionImplementation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
