bkietz commented on code in PR #39067:
URL: https://github.com/apache/arrow/pull/39067#discussion_r1511464750
##########
cpp/src/arrow/filesystem/filesystem.cc:
##########
@@ -674,6 +684,134 @@ Status CopyFiles(const std::shared_ptr<FileSystem>&
source_fs,
return CopyFiles(sources, destinations, io_context, chunk_size, use_threads);
}
+class FileSystemFactoryRegistry {
+ public:
+ static FileSystemFactoryRegistry* GetInstance() {
+ static FileSystemFactoryRegistry registry;
+ return ®istry;
+ }
+
+ Result<FileSystemFactory*> FactoryForScheme(const std::string& scheme) {
+ std::shared_lock lock{mutex_};
+ if (finalized_) return AlreadyFinalized();
+
+ auto it = scheme_to_factory_.find(scheme);
+ if (it == scheme_to_factory_.end()) return nullptr;
+
+ return it->second.Map([](const auto& r) { return r.factory; });
+ }
+
+ Status MergeInto(FileSystemFactoryRegistry* main_registry) {
+ std::shared_lock lock{mutex_};
Review Comment:
no it's not! copy paste error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
