bkietz commented on code in PR #39067:
URL: https://github.com/apache/arrow/pull/39067#discussion_r1511470928
##########
cpp/src/arrow/filesystem/filesystem.h:
##########
@@ -458,16 +490,25 @@ class ARROW_EXPORT SlowFileSystem : public FileSystem {
const FileInfo& info) override;
Result<std::shared_ptr<io::OutputStream>> OpenOutputStream(
const std::string& path,
- const std::shared_ptr<const KeyValueMetadata>& metadata = {}) override;
+ const std::shared_ptr<const KeyValueMetadata>& metadata) override;
Result<std::shared_ptr<io::OutputStream>> OpenAppendStream(
const std::string& path,
- const std::shared_ptr<const KeyValueMetadata>& metadata = {}) override;
+ const std::shared_ptr<const KeyValueMetadata>& metadata) override;
protected:
std::shared_ptr<FileSystem> base_fs_;
std::shared_ptr<io::LatencyGenerator> latencies_;
};
+/// \brief Ensure all registered filesystem implementations are finalized.
+///
+/// Individual finalizers may wait for concurrent calls to finish so as to
avoid
+/// race conditions. After this function has been called, all filesystem APIs
+/// will fail with an error.
+///
+/// The user is responsible for synchronization of calls to this function.
+void EnsureFinalized();
Review Comment:
Yes, I plan to have built in filesystems registered with their finalizers so
that S3 will be handled by this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
