tustvold commented on code in PR #5471:
URL: https://github.com/apache/arrow-rs/pull/5471#discussion_r1511923349
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -244,16 +244,35 @@ impl<W: Write + Send> ArrowWriter<W> {
self.writer.append_key_value_metadata(kv_metadata)
}
+ /// Returns a reference to the underlying writer.
+ pub fn inner(&self) -> &W {
+ self.writer.inner()
+ }
+
+ /// Returns a mutable reference to the underlying writer.
+ ///
+ /// It is inadvisable to directly write to the underlying writer.
Review Comment:
This is copied from the docs on `std::io::BufWriter`, which is effectively
what this is.
One could argue that exposing this is dangerous as they could potentially
mess with the writer underneath us, but I think this is fine because the
standard library does this, and there isn't anything to stop them using a
writer with interior mutability anyway (as AsyncArrowWriter in fact did)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
