felipecrv commented on code in PR #40147:
URL: https://github.com/apache/arrow/pull/40147#discussion_r1512875788
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -2145,7 +2166,10 @@ class S3FileSystem::Impl : public
std::enable_shared_from_this<S3FileSystem::Imp
child_path_ss << bucket << kSep << child_key;
child_key = child_path_ss.str();
if (obj.GetSize() > 0 || !had_trailing_slash) {
- // We found a real file
+ // We found a real file.
+ // XXX Ideally, for 0-sized files we would also check the
Content-Type
+ // against kAwsDirectoryContentType, but ListObjectsV2 does not
give
+ // that information.
Review Comment:
I checked the issue and I think supporting directories with
trailing-slash-less keys + requiring that files never have a trailing-slash is
enough to solve it. And won't create more issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
