felipecrv commented on code in PR #40147:
URL: https://github.com/apache/arrow/pull/40147#discussion_r1513129138
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -2145,7 +2166,10 @@ class S3FileSystem::Impl : public
std::enable_shared_from_this<S3FileSystem::Imp
child_path_ss << bucket << kSep << child_key;
child_key = child_path_ss.str();
if (obj.GetSize() > 0 || !had_trailing_slash) {
- // We found a real file
+ // We found a real file.
+ // XXX Ideally, for 0-sized files we would also check the
Content-Type
+ // against kAwsDirectoryContentType, but ListObjectsV2 does not
give
+ // that information.
Review Comment:
> I agree it's not very pretty, but if it solves a real issue for users,
then we should probably do it IMHO.
The restriction I'm asking for doesn't prevent the issue to be fixed. We can
support directories on paths not ending with a `/`. I'm asking to not expand
the scope of the fix to also allow files on paths with trailing `/`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
