huaxingao commented on code in PR #9470:
URL: https://github.com/apache/arrow-datafusion/pull/9470#discussion_r1513625140
##########
datafusion/physical-expr/src/window/nth_value.rs:
##########
@@ -79,14 +84,19 @@ impl NthValue {
expr: Arc<dyn PhysicalExpr>,
data_type: DataType,
n: u32,
+ ignore_nulls: bool,
) -> Result<Self> {
+ if ignore_nulls {
+ return exec_err!("NTH_VALUE ignore_nulls is not supported yet");
Review Comment:
I will have a separate PR for this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
