viirya commented on code in PR #9470:
URL: https://github.com/apache/arrow-datafusion/pull/9470#discussion_r1516614217
##########
datafusion/physical-expr/src/window/nth_value.rs:
##########
@@ -42,6 +42,7 @@ pub struct NthValue {
/// Output data type
data_type: DataType,
kind: NthValueKind,
+ ignore_nulls: bool,
Review Comment:
This is also for `NTH_VALUE` right?
##########
datafusion/physical-expr/src/window/nth_value.rs:
##########
@@ -42,6 +42,7 @@ pub struct NthValue {
/// Output data type
data_type: DataType,
kind: NthValueKind,
+ ignore_nulls: bool,
Review Comment:
This is also for `NTH_VALUE` right? Maybe add it to the title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
