pitrou commented on code in PR #40372: URL: https://github.com/apache/arrow/pull/40372#discussion_r1514157929
########## cpp/src/arrow/util/visibility.h: ########## @@ -52,13 +52,13 @@ #endif #define ARROW_NO_EXPORT -#define ARROW_FORCE_INLINE __forceinline +#define ARROW_ALWAYS_INLINE __forceinline #else // Non-Windows -#define ARROW_FORCE_INLINE +#define ARROW_ALWAYS_INLINE __attribute__((always_inline)) Review Comment: Are we sure this exists on all compilers or should it be gcc- and clang-specific? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
