felipecrv commented on code in PR #40372: URL: https://github.com/apache/arrow/pull/40372#discussion_r1514851209
########## cpp/src/arrow/util/macros.h: ########## @@ -49,10 +49,12 @@ #define ARROW_PREDICT_TRUE(x) (__builtin_expect(!!(x), 1)) #define ARROW_NORETURN __attribute__((noreturn)) #define ARROW_NOINLINE __attribute__((noinline)) +#define ARROW_FORCE_INLINE __attribute__((always_inline)) #define ARROW_PREFETCH(addr) __builtin_prefetch(addr) #elif defined(_MSC_VER) #define ARROW_NORETURN __declspec(noreturn) #define ARROW_NOINLINE __declspec(noinline) +#define ARROW_FORCE_INLINE __declspec(forceinline) Review Comment: Done. Interestingly `ARROW_NOINLINE` was missing the empty fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
