tustvold commented on code in PR #5479:
URL: https://github.com/apache/arrow-rs/pull/5479#discussion_r1515188617
##########
arrow-array/src/temporal_conversions.rs:
##########
@@ -130,45 +131,48 @@ pub fn time_to_time64ns(v: NaiveTime) -> i64 {
/// converts a `i64` representing a `timestamp(s)` to [`NaiveDateTime`]
#[inline]
pub fn timestamp_s_to_datetime(v: i64) -> Option<NaiveDateTime> {
- NaiveDateTime::from_timestamp_opt(v, 0)
+ Some(DateTime::from_timestamp(v, 0)?.naive_utc())
Review Comment:
https://github.com/apache/arrow-rs/issues/5480 tracks cleaning up these APIs
to return `DateTime<Utc>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]