alamb commented on code in PR #5479:
URL: https://github.com/apache/arrow-rs/pull/5479#discussion_r1516883640
##########
arrow-array/src/temporal_conversions.rs:
##########
@@ -179,13 +183,13 @@ pub(crate) fn split_second(v: i64, base: i64) -> (i64,
u32) {
/// converts a `i64` representing a `duration(s)` to [`Duration`]
#[inline]
pub fn duration_s_to_duration(v: i64) -> Duration {
- Duration::seconds(v)
+ Duration::try_seconds(v).unwrap()
Review Comment:
is there any performance implication here (e.g. starting to check for
invalid durations when we didn't before)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
