zeroshade commented on code in PR #1593:
URL: https://github.com/apache/arrow-adbc/pull/1593#discussion_r1516614059
##########
go/adbc/driver/snowflake/connection.go:
##########
@@ -557,13 +587,204 @@ func (c *cnxn) populateMetadata(ctx context.Context,
depth adbc.ObjectDepth, cat
return metadataRecords, nil
}
+func (c *cnxn) populateConstraintSchema(ctx context.Context, depth
adbc.ObjectDepth, metadataRecords []internal.Metadata)
(map[internal.CatalogSchemaTable][]internal.ConstraintSchema, error) {
+ constraintLookup :=
make(map[internal.CatalogSchemaTable][]internal.ConstraintSchema)
+ tableConstraintsData, err := c.getConstraintsData(ctx, depth,
metadataRecords)
+ if err != nil {
+ return nil, err
+ }
+
+ fullyQualifiedConstraintSchemaLookup :=
make(map[string]internal.ConstraintSchema)
+ for _, data := range tableConstraintsData {
+ var fullyQualifiedConstraintName string
+ if data.fk_constraintName.Valid {
+ fullyQualifiedConstraintName =
getFullyQualifiedConstraintName(data.fkDbName.String, data.fkSchema.String,
data.fkTblName.String, data.fk_constraintName.String)
+ if _, exists :=
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName]; !exists {
+
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName] =
internal.ConstraintSchema{
+ ConstraintName:
data.fk_constraintName.String,
+ ConstraintType:
data.constraintType,
+ ConstraintColumnNames:
[]string{data.fkColName.String},
+ ConstraintColumnUsages:
[]internal.UsageSchema{
+ {
+ ForeignKeyCatalog:
data.dbName,
+ ForeignKeyDbSchema:
data.schema,
+ ForeignKeyTable:
data.tblName,
+ ForeignKeyColName:
data.colName,
+ },
+ },
+ }
+ } else {
+ constraintInfo :=
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName]
+ constraintInfo.ConstraintColumnNames =
append(constraintInfo.ConstraintColumnNames, data.fkColName.String)
+
+ constraintInfo.ConstraintColumnUsages =
append(constraintInfo.ConstraintColumnUsages, internal.UsageSchema{
+ ForeignKeyCatalog: data.dbName,
+ ForeignKeyDbSchema: data.schema,
+ ForeignKeyTable: data.tblName,
+ ForeignKeyColName: data.colName,
+ })
+
+
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName] =
constraintInfo
+ }
+ } else {
+ fullyQualifiedConstraintName =
getFullyQualifiedConstraintName(data.dbName, data.schema, data.tblName,
data.constraintName)
+ if _, exists :=
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName]; !exists {
+
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName] =
internal.ConstraintSchema{
+ ConstraintName:
data.constraintName,
+ ConstraintType:
data.constraintType,
+ ConstraintColumnNames:
[]string{data.colName},
+ }
+ } else {
+ constraintInfo :=
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName]
+ constraintInfo.ConstraintColumnNames =
append(constraintInfo.ConstraintColumnNames, data.colName)
+
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName] =
constraintInfo
+ }
+ }
+ }
+
+ for key, constraintSchema := range fullyQualifiedConstraintSchemaLookup
{
+ catalogSchemaTable :=
getCatalogSchemaTableFromFullyQualifiedConstraintName(key)
+ constraintLookup[catalogSchemaTable] =
append(constraintLookup[catalogSchemaTable], constraintSchema)
+ }
+
+ return constraintLookup, nil
+}
+
+func (c *cnxn) getConstraintsData(ctx context.Context, depth adbc.ObjectDepth,
metadataRecords []internal.Metadata) ([]TableConstraint, error) {
+ if depth == adbc.ObjectDepthCatalogs || depth ==
adbc.ObjectDepthDBSchemas {
+ return nil, nil
+ }
+ availableConstraintTypes := getAvailableConstraintTypes(metadataRecords)
+ availableFullyQualifiedConstraints :=
getAvailableFullyQualifiedConstraints(metadataRecords)
+
+ var uniqueConstraintsData []TableConstraint
+ var primaryKeyConstraintsData []TableConstraint
+ var foreignKeyConstraintsData []TableConstraint
+ var err error
+
+ if availableConstraintTypes != nil {
+ if _, exists := availableConstraintTypes[internal.Unique];
exists {
+ uniqueConstraintsData, err =
c.getUniqueConstraints(ctx, availableFullyQualifiedConstraints)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ }
+
+ if _, exists := availableConstraintTypes[internal.PrimaryKey];
exists {
+ primaryKeyConstraintsData, err =
c.getPrimaryKeyConstraints(ctx, availableFullyQualifiedConstraints)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ }
+
+ if _, exists := availableConstraintTypes[internal.ForeignKey];
exists {
+ foreignKeyConstraintsData, err =
c.getForeignKeyConstraints(ctx, availableFullyQualifiedConstraints)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ }
+ }
+
+ tableConstraintsData := append(append(uniqueConstraintsData,
primaryKeyConstraintsData...), foreignKeyConstraintsData...)
+
+ sort.Slice(tableConstraintsData, func(i, j int) bool {
+ if tableConstraintsData[i].constraintName ==
tableConstraintsData[j].constraintName {
+ return tableConstraintsData[i].keySequence <
tableConstraintsData[j].keySequence
+ }
+ return tableConstraintsData[i].constraintName ==
tableConstraintsData[j].constraintName
+ })
+
+ return tableConstraintsData, nil
+}
+
+func (c *cnxn) getUniqueConstraints(ctx context.Context,
fullyQualifiedConstraints map[string]bool) ([]TableConstraint, error) {
+ uniqueConstraintsData := make([]TableConstraint, 0)
+
+ rows, err := c.sqldb.QueryContext(ctx, prepareUniqueConstraintSQL(),
nil)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ defer rows.Close()
+
+ for rows.Next() {
+ var uniqueConstraint TableConstraint
+ if err := rows.Scan(&uniqueConstraint.skipCreatedOn,
&uniqueConstraint.dbName, &uniqueConstraint.schema, &uniqueConstraint.tblName,
&uniqueConstraint.colName, &uniqueConstraint.keySequence,
&uniqueConstraint.constraintName, &uniqueConstraint.skipRely,
&uniqueConstraint.skipComment); err != nil {
+ return nil, errToAdbcErr(adbc.StatusInvalidData, err)
+ }
+
+ currentConstraintQualifiedName :=
getFullyQualifiedConstraintName(uniqueConstraint.dbName,
uniqueConstraint.schema, uniqueConstraint.tblName,
uniqueConstraint.constraintName)
+
+ // skip constraint if it doesn't exist in
fullyQualifiedConstraints
+ if _, exists :=
fullyQualifiedConstraints[currentConstraintQualifiedName]; exists {
+ uniqueConstraint.constraintType = internal.Unique
+ uniqueConstraintsData = append(uniqueConstraintsData,
uniqueConstraint)
+ }
+
+ }
+ return uniqueConstraintsData, nil
+}
+
+func (c *cnxn) getPrimaryKeyConstraints(ctx context.Context,
fullyQualifiedConstraints map[string]bool) ([]TableConstraint, error) {
+ primaryKeyConstraintsData := make([]TableConstraint, 0)
+
+ rows, err := c.sqldb.QueryContext(ctx,
preparePrimaryKeyConstraintSQL(), nil)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ defer rows.Close()
+
+ for rows.Next() {
+ var primaryKeyConstraint TableConstraint
+ if err := rows.Scan(&primaryKeyConstraint.skipCreatedOn,
&primaryKeyConstraint.dbName, &primaryKeyConstraint.schema,
&primaryKeyConstraint.tblName, &primaryKeyConstraint.colName,
&primaryKeyConstraint.keySequence, &primaryKeyConstraint.constraintName,
&primaryKeyConstraint.skipRely, &primaryKeyConstraint.skipComment); err != nil {
Review Comment:
split the line to make this easier to read
##########
go/adbc/driver/snowflake/connection.go:
##########
@@ -557,13 +587,204 @@ func (c *cnxn) populateMetadata(ctx context.Context,
depth adbc.ObjectDepth, cat
return metadataRecords, nil
}
+func (c *cnxn) populateConstraintSchema(ctx context.Context, depth
adbc.ObjectDepth, metadataRecords []internal.Metadata)
(map[internal.CatalogSchemaTable][]internal.ConstraintSchema, error) {
+ constraintLookup :=
make(map[internal.CatalogSchemaTable][]internal.ConstraintSchema)
+ tableConstraintsData, err := c.getConstraintsData(ctx, depth,
metadataRecords)
+ if err != nil {
+ return nil, err
+ }
+
+ fullyQualifiedConstraintSchemaLookup :=
make(map[string]internal.ConstraintSchema)
+ for _, data := range tableConstraintsData {
+ var fullyQualifiedConstraintName string
+ if data.fk_constraintName.Valid {
+ fullyQualifiedConstraintName =
getFullyQualifiedConstraintName(data.fkDbName.String, data.fkSchema.String,
data.fkTblName.String, data.fk_constraintName.String)
+ if _, exists :=
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName]; !exists {
+
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName] =
internal.ConstraintSchema{
+ ConstraintName:
data.fk_constraintName.String,
+ ConstraintType:
data.constraintType,
+ ConstraintColumnNames:
[]string{data.fkColName.String},
+ ConstraintColumnUsages:
[]internal.UsageSchema{
+ {
+ ForeignKeyCatalog:
data.dbName,
+ ForeignKeyDbSchema:
data.schema,
+ ForeignKeyTable:
data.tblName,
+ ForeignKeyColName:
data.colName,
+ },
+ },
+ }
+ } else {
+ constraintInfo :=
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName]
+ constraintInfo.ConstraintColumnNames =
append(constraintInfo.ConstraintColumnNames, data.fkColName.String)
+
+ constraintInfo.ConstraintColumnUsages =
append(constraintInfo.ConstraintColumnUsages, internal.UsageSchema{
+ ForeignKeyCatalog: data.dbName,
+ ForeignKeyDbSchema: data.schema,
+ ForeignKeyTable: data.tblName,
+ ForeignKeyColName: data.colName,
+ })
+
+
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName] =
constraintInfo
+ }
+ } else {
+ fullyQualifiedConstraintName =
getFullyQualifiedConstraintName(data.dbName, data.schema, data.tblName,
data.constraintName)
+ if _, exists :=
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName]; !exists {
+
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName] =
internal.ConstraintSchema{
+ ConstraintName:
data.constraintName,
+ ConstraintType:
data.constraintType,
+ ConstraintColumnNames:
[]string{data.colName},
+ }
+ } else {
+ constraintInfo :=
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName]
+ constraintInfo.ConstraintColumnNames =
append(constraintInfo.ConstraintColumnNames, data.colName)
+
fullyQualifiedConstraintSchemaLookup[fullyQualifiedConstraintName] =
constraintInfo
+ }
+ }
+ }
+
+ for key, constraintSchema := range fullyQualifiedConstraintSchemaLookup
{
+ catalogSchemaTable :=
getCatalogSchemaTableFromFullyQualifiedConstraintName(key)
+ constraintLookup[catalogSchemaTable] =
append(constraintLookup[catalogSchemaTable], constraintSchema)
+ }
+
+ return constraintLookup, nil
+}
+
+func (c *cnxn) getConstraintsData(ctx context.Context, depth adbc.ObjectDepth,
metadataRecords []internal.Metadata) ([]TableConstraint, error) {
+ if depth == adbc.ObjectDepthCatalogs || depth ==
adbc.ObjectDepthDBSchemas {
+ return nil, nil
+ }
+ availableConstraintTypes := getAvailableConstraintTypes(metadataRecords)
+ availableFullyQualifiedConstraints :=
getAvailableFullyQualifiedConstraints(metadataRecords)
+
+ var uniqueConstraintsData []TableConstraint
+ var primaryKeyConstraintsData []TableConstraint
+ var foreignKeyConstraintsData []TableConstraint
+ var err error
+
+ if availableConstraintTypes != nil {
+ if _, exists := availableConstraintTypes[internal.Unique];
exists {
+ uniqueConstraintsData, err =
c.getUniqueConstraints(ctx, availableFullyQualifiedConstraints)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ }
+
+ if _, exists := availableConstraintTypes[internal.PrimaryKey];
exists {
+ primaryKeyConstraintsData, err =
c.getPrimaryKeyConstraints(ctx, availableFullyQualifiedConstraints)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ }
+
+ if _, exists := availableConstraintTypes[internal.ForeignKey];
exists {
+ foreignKeyConstraintsData, err =
c.getForeignKeyConstraints(ctx, availableFullyQualifiedConstraints)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ }
+ }
+
+ tableConstraintsData := append(append(uniqueConstraintsData,
primaryKeyConstraintsData...), foreignKeyConstraintsData...)
+
+ sort.Slice(tableConstraintsData, func(i, j int) bool {
+ if tableConstraintsData[i].constraintName ==
tableConstraintsData[j].constraintName {
+ return tableConstraintsData[i].keySequence <
tableConstraintsData[j].keySequence
+ }
+ return tableConstraintsData[i].constraintName ==
tableConstraintsData[j].constraintName
+ })
+
+ return tableConstraintsData, nil
+}
+
+func (c *cnxn) getUniqueConstraints(ctx context.Context,
fullyQualifiedConstraints map[string]bool) ([]TableConstraint, error) {
+ uniqueConstraintsData := make([]TableConstraint, 0)
+
+ rows, err := c.sqldb.QueryContext(ctx, prepareUniqueConstraintSQL(),
nil)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ defer rows.Close()
+
+ for rows.Next() {
+ var uniqueConstraint TableConstraint
+ if err := rows.Scan(&uniqueConstraint.skipCreatedOn,
&uniqueConstraint.dbName, &uniqueConstraint.schema, &uniqueConstraint.tblName,
&uniqueConstraint.colName, &uniqueConstraint.keySequence,
&uniqueConstraint.constraintName, &uniqueConstraint.skipRely,
&uniqueConstraint.skipComment); err != nil {
+ return nil, errToAdbcErr(adbc.StatusInvalidData, err)
+ }
+
+ currentConstraintQualifiedName :=
getFullyQualifiedConstraintName(uniqueConstraint.dbName,
uniqueConstraint.schema, uniqueConstraint.tblName,
uniqueConstraint.constraintName)
+
+ // skip constraint if it doesn't exist in
fullyQualifiedConstraints
+ if _, exists :=
fullyQualifiedConstraints[currentConstraintQualifiedName]; exists {
+ uniqueConstraint.constraintType = internal.Unique
+ uniqueConstraintsData = append(uniqueConstraintsData,
uniqueConstraint)
+ }
+
+ }
+ return uniqueConstraintsData, nil
+}
+
+func (c *cnxn) getPrimaryKeyConstraints(ctx context.Context,
fullyQualifiedConstraints map[string]bool) ([]TableConstraint, error) {
+ primaryKeyConstraintsData := make([]TableConstraint, 0)
+
+ rows, err := c.sqldb.QueryContext(ctx,
preparePrimaryKeyConstraintSQL(), nil)
+ if err != nil {
+ return nil, errToAdbcErr(adbc.StatusIO, err)
+ }
+ defer rows.Close()
+
+ for rows.Next() {
+ var primaryKeyConstraint TableConstraint
+ if err := rows.Scan(&primaryKeyConstraint.skipCreatedOn,
&primaryKeyConstraint.dbName, &primaryKeyConstraint.schema,
&primaryKeyConstraint.tblName, &primaryKeyConstraint.colName,
&primaryKeyConstraint.keySequence, &primaryKeyConstraint.constraintName,
&primaryKeyConstraint.skipRely, &primaryKeyConstraint.skipComment); err != nil {
+ return nil, errToAdbcErr(adbc.StatusInvalidData, err)
+ }
+
+ currentConstraintQualifiedName :=
getFullyQualifiedConstraintName(primaryKeyConstraint.dbName,
primaryKeyConstraint.schema, primaryKeyConstraint.tblName,
primaryKeyConstraint.constraintName)
Review Comment:
split the line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
