ryan-syed commented on code in PR #1593:
URL: https://github.com/apache/arrow-adbc/pull/1593#discussion_r1516814311
##########
csharp/test/Apache.Arrow.Adbc.Tests/Metadata/GetObjectsParser.cs:
##########
@@ -173,6 +173,14 @@ private static List<AdbcConstraint>
ParseConstraints(StructArray constraintsArra
StringArray col_names = column_names.GetSlicedValues(i) as
StringArray;
StructArray usage = column_usage.GetSlicedValues(i) as
StructArray;
+ if (col_names != null)
+ {
+ for (int j = 0; j < col_names.Length; j++)
Review Comment:
Here the columns are for composite keys. Though Snowflake doesn't set a
limit for it, most other SQL databases set a limit of 16 to 32 on composite
indexes. It is 16 for
[MySQL](https://dev.mysql.com/doc/refman/8.0/en/multiple-column-indexes.html#:~:text=10.3.6%C2%A0Multiple%2DColumn,Column%20Indexes%E2%80%9D).
For most practical cases, it would be 1-2 columns. Reserving capacity for it
may give minimal performance gains. What do you suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
