mbostock commented on code in PR #40408:
URL: https://github.com/apache/arrow/pull/40408#discussion_r1516800922
##########
js/src/row/map.ts:
##########
@@ -107,7 +107,7 @@ class MapRowProxyHandler<K extends DataType = any, V
extends DataType = any> imp
deleteProperty() { return false; }
preventExtensions() { return true; }
ownKeys(row: MapRow<K, V>) {
- return row[kKeys].toArray().map(String);
+ return Array.from(row[kKeys].toArray(), String);
}
has(row: MapRow<K, V>, key: string | symbol) {
return row[kKeys].includes(key);
Review Comment:
I’m not familiar enough with this codebase to do it confidently and to test.
I’d welcome someone else doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
