felipecrv commented on code in PR #40147:
URL: https://github.com/apache/arrow/pull/40147#discussion_r1512866075
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -1214,6 +1215,24 @@ Status SetObjectMetadata(const std::shared_ptr<const
KeyValueMetadata>& metadata
return Status::OK();
}
+bool IsDirectory(std::string_view key, const S3Model::HeadObjectResult&
result) {
+ // If it has a non-zero length, it's a regular file
+ if (result.GetContentLength() > 0) {
+ return false;
+ }
+ // Otherwise, if it has a trailing slash, it's a directory
+ if (internal::HasTrailingSlash(key)) {
+ return true;
+ }
+ // Otherwise, if its content type starts with "application/x-directory",
+ // it's a directory
+ if (::arrow::internal::StartsWith(result.GetContentType(),
kAwsDirectoryContentType)) {
+ return true;
+ }
Review Comment:
This we can support: directories that don't end in a `/`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
