BryanCutler commented on a change in pull request #9151:
URL: https://github.com/apache/arrow/pull/9151#discussion_r570608317
##########
File path: java/vector/src/main/codegen/templates/UnionFixedSizeListWriter.java
##########
@@ -169,6 +169,29 @@ public StructWriter struct(String name) {
return structWriter;
}
+ @Override
+ public MapWriter map() {
+ return writer;
+ }
+
+ @Override
+ public MapWriter map(String name) {
+ MapWriter mapWriter = writer.map(name);
+ return mapWriter;
+ }
+
+ @Override
+ public MapWriter map(boolean keysSorted) {
+ writer.map(keysSorted);
Review comment:
It should work pretty much like `ListWriter` and this isn't how
`ListWriter` is done in this class, so something doesn't seem quite right, but
I could be wrong. I'll try to look into it and see what's going on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
