BryanCutler commented on a change in pull request #9151:
URL: https://github.com/apache/arrow/pull/9151#discussion_r570609184
##########
File path: java/vector/src/main/codegen/templates/StructWriters.java
##########
@@ -184,6 +189,44 @@ public ListWriter list(String name) {
return writer;
}
+ @Override
+ public MapWriter map(String name) {
+ // returns existing writer
+ final FieldWriter writer = fields.get(handleCase(name));
+ Preconditions.checkNotNull(writer);
Review comment:
We should probably have the writer default to `keysSorted=false` since
that will be the most common usage and would only be used if someone really
needed this flag. Would that allow you to change this to create a writer by
default then, and only supply `keysSorted` optionally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
