pitrou commented on code in PR #40253:
URL: https://github.com/apache/arrow/pull/40253#discussion_r1518589709
##########
cpp/src/arrow/util/span_test.cc:
##########
@@ -51,7 +51,6 @@ TEST(Span, Construction) {
static_assert(std::is_constructible_v<span<const int>, decltype(arr)&>);
static_assert(std::is_constructible_v<span<const int>,
decltype(const_arr)&>);
- static_assert(std::is_constructible_v<span<const int>, span<int>>);
Review Comment:
Hmm... does this mean conversion from `span<T>` to `span<const T>` doesn't
work anymore?
##########
cpp/src/arrow/util/span.h:
##########
@@ -25,6 +25,18 @@
namespace arrow::util {
+template <class T>
+class span;
+
+template <class T, class R, class Enable = void>
+struct ConstructibleFromDataAndSize : std::false_type {};
+
+template <class T, class R>
Review Comment:
Can you add a comment explaining why this construct is needed, and pointing
to the GH issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
