vyasr commented on code in PR #40253:
URL: https://github.com/apache/arrow/pull/40253#discussion_r1519021859
##########
cpp/src/arrow/util/span_test.cc:
##########
@@ -51,7 +51,6 @@ TEST(Span, Construction) {
static_assert(std::is_constructible_v<span<const int>, decltype(arr)&>);
static_assert(std::is_constructible_v<span<const int>,
decltype(const_arr)&>);
- static_assert(std::is_constructible_v<span<const int>, span<int>>);
Review Comment:
Nope. Sorry I meant to leave this comment on this PR but forgot, but the
reason I removed this line is because it's redundant. The same check already
exists on line 42. I noticed it while experimenting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
