viirya commented on code in PR #178:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/178#discussion_r1518631909
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -547,7 +571,9 @@ object CometSparkSessionExtensions extends Logging {
private[comet] def isCometOperatorEnabled(conf: SQLConf, operator: String):
Boolean = {
val operatorFlag = s"$COMET_EXEC_CONFIG_PREFIX.$operator.enabled"
- conf.getConfString(operatorFlag, "false").toBoolean ||
isCometAllOperatorEnabled(conf)
+ val operatorDisabledFlag = s"$COMET_EXEC_CONFIG_PREFIX.$operator.disabled"
+ conf.getConfString(operatorFlag, "false").toBoolean ||
isCometAllOperatorEnabled(conf) &&
+ !conf.getConfString(operatorDisabledFlag, "false").toBoolean
Review Comment:
This "disable" flag is useful to disable a particular operator in unit test.
For example, I disable sort merge join in one existing test below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
