huaxingao commented on code in PR #178:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/178#discussion_r1518647049
##########
common/src/main/java/org/apache/comet/vector/CometPlainVector.java:
##########
@@ -113,7 +113,11 @@ public UTF8String getUTF8String(int rowId) {
byte[] result = new byte[length];
Platform.copyMemory(
null, valueBufferAddress + offset, result,
Platform.BYTE_ARRAY_OFFSET, length);
- return UTF8String.fromString(convertToUuid(result).toString());
+ if (length == 16) {
+ return UTF8String.fromString(convertToUuid(result).toString());
+ } else {
+ return UTF8String.fromBytes(result);
+ }
Review Comment:
The UUID support is mainly for iceberg integration. Iceberg maps UUID to
String type. On comet side, if we want to find out if the String column is UUID
or not, when creating a `ColumnReader` on iceberg side, we need to add one more
parameter to indicator if the column is UUID or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
