ianmcook commented on code in PR #12:
URL: https://github.com/apache/arrow-experiments/pull/12#discussion_r1518656363
##########
http/get_simple/python/server/server.py:
##########
@@ -58,8 +58,6 @@ def make_reader(schema, batches):
def generate_batches(schema, reader):
with io.BytesIO() as sink, pa.ipc.new_stream(sink, schema) as writer:
- yield sink.getvalue()
-
Review Comment:
@paleolimbot is this safe to remove? It was included here because I followed
your example at
https://github.com/paleolimbot/2023-11-21_arrow-over-http-scratchpad/blob/main/app.py#L17-L30
as discussed at
https://github.com/apache/arrow/pull/39081#discussion_r1416270794. But I
believe it always just yields an empty bytestring, which caused errors with
chunked transfer encoding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
