paleolimbot commented on code in PR #12:
URL: https://github.com/apache/arrow-experiments/pull/12#discussion_r1518709151
##########
http/get_simple/python/server/server.py:
##########
@@ -58,8 +58,6 @@ def make_reader(schema, batches):
def generate_batches(schema, reader):
with io.BytesIO() as sink, pa.ipc.new_stream(sink, schema) as writer:
- yield sink.getvalue()
-
Review Comment:
I think it was supposed to yield the schema bytes (which I think, but don't
know, are written to sink by `new_stream`). This might not be happening, or
there might be some buffered writing happening that means that sometimes the
schema hasn't been flushed into the BytesIO by Arrow yet. It is probably worth
checking!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
